Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2402)

Unified Diff: core/html/HTMLAllCollection.idl

Issue 1660113002: Updated to Chrome 45 (2454) moved from SVN to git. Base URL: https://github.com/dart-lang/webcore.git@roll_45
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « core/html/FormData.idl ('k') | core/html/HTMLAnchorElement.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: core/html/HTMLAllCollection.idl
diff --git a/core/html/HTMLAllCollection.idl b/core/html/HTMLAllCollection.idl
index d56b8b6dbf560bd7fab369a2cfa1052ea5f9a1ee..40c7fc47efdcbcc9ceb146139ab53eaac2af7ef9 100644
--- a/core/html/HTMLAllCollection.idl
+++ b/core/html/HTMLAllCollection.idl
@@ -24,6 +24,8 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
+// https://html.spec.whatwg.org/#the-htmlallcollection-interface
+
// FIXME: This interface should inherit HTMLCollection.
[
Custom=LegacyCallAsFunction,
@@ -31,9 +33,14 @@
SetWrapperReferenceFrom=ownerNode,
WillBeGarbageCollected,
] interface HTMLAllCollection {
+ // FIXME: length and 'getter' should be inherited from HTMLCollection.
readonly attribute unsigned long length;
[ImplementedAs=item] getter Element (unsigned long index);
- [Custom] Element item([Default=Undefined] optional unsigned long index);
- // FIXME: This should return an (HTMLCollection or Element) union.
- [ImplementedAs=namedGetter] getter (NodeList or Element) namedItem(DOMString name);
+ // FIXME: The custom item() implementation may return a NodeList, but the
+ // spec has a (HTMLCollection or Element)? item(DOMString name) method.
+ [Custom] Element? item([Default=Undefined] optional unsigned long index);
+ // FIXME:
+ // FIXME: namedItem() should be a legacycaller. crbug.com/465009
+ // FIXME: namedItem() should return an (HTMLCollection or Element)? union.
+ [ImplementedAs=namedGetter] getter (NodeList or Element)? namedItem(DOMString name);
};
« no previous file with comments | « core/html/FormData.idl ('k') | core/html/HTMLAnchorElement.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698