Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: core/html/track/vtt/VTTRegion.idl

Issue 1660113002: Updated to Chrome 45 (2454) moved from SVN to git. Base URL: https://github.com/dart-lang/webcore.git@roll_45
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « core/html/track/vtt/VTTCue.idl ('k') | core/html/track/vtt/VTTRegionList.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: core/html/track/vtt/VTTRegion.idl
diff --git a/core/html/track/vtt/VTTRegion.idl b/core/html/track/vtt/VTTRegion.idl
index 1a28e70b4dab1c0ffa9bffe99b94716d19ce8ae9..3f18b15b416c382474e9cfe2f3f9298714bef091 100644
--- a/core/html/track/vtt/VTTRegion.idl
+++ b/core/html/track/vtt/VTTRegion.idl
@@ -23,20 +23,25 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
+// http://dev.w3.org/html5/webvtt/#the-vttregion-interface
+
[
Constructor,
RuntimeEnabled=WebVTTRegions,
- TypeChecking=Unrestricted,
WillBeGarbageCollected,
] interface VTTRegion {
- readonly attribute TextTrack track;
-
- attribute DOMString id;
[RaisesException=Setter] attribute double width;
+ // TODO(philipj): height should be called lines.
[RaisesException=Setter] attribute long height;
[RaisesException=Setter] attribute double regionAnchorX;
[RaisesException=Setter] attribute double regionAnchorY;
[RaisesException=Setter] attribute double viewportAnchorX;
[RaisesException=Setter] attribute double viewportAnchorY;
+ // TODO(philip): scroll should be of type ScrollSetting.
[RaisesException=Setter] attribute DOMString scroll;
+
+ // TODO(philipj): The track/id attributes are gone from the spec:
+ // https://www.w3.org/Bugs/Public/show_bug.cgi?id=24380
+ readonly attribute TextTrack track;
+ attribute DOMString id;
};
« no previous file with comments | « core/html/track/vtt/VTTCue.idl ('k') | core/html/track/vtt/VTTRegionList.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698