Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1795)

Unified Diff: bindings/dart/gyp/scripts/build_dart_snapshot.py

Issue 1660113002: Updated to Chrome 45 (2454) moved from SVN to git. Base URL: https://github.com/dart-lang/webcore.git@roll_45
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « bindings/README ('k') | bindings/dart/scripts/__init__.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: bindings/dart/gyp/scripts/build_dart_snapshot.py
diff --git a/bindings/dart/gyp/scripts/build_dart_snapshot.py b/bindings/dart/gyp/scripts/build_dart_snapshot.py
index 323f38a0dbffa31c9a13c8c8328b5392e2808fc4..4efc7172d2bcc0f944ff41de7413121fb3206cc7 100755
--- a/bindings/dart/gyp/scripts/build_dart_snapshot.py
+++ b/bindings/dart/gyp/scripts/build_dart_snapshot.py
@@ -68,15 +68,18 @@ def main(args):
# Skip internal libraries - they should be indirectly imported via the public ones.
if not name.startswith('_'):
snapshotScript.write('import \'dart:%(name)s\' as %(name)s;\n' % {'name': name})
+ snapshotScript.write('import \'dart:vmserviceio\';\n')
- binarySnapshotFile = path(outputFilePath, 'DartSnapshot.bin')
+ binaryVmIsolateSnapshotFile = path(outputFilePath, 'DartVmIsolateSnapshot.bin')
+ binaryIsolateSnapshotFile = path(outputFilePath, 'DartIsolateSnapshot.bin')
# Build a command to generate the snapshot bin file.
command = [
'python',
path(dartPath, 'runtime', 'tools', 'create_snapshot_bin.py'),
'--executable=%s' % path(genSnapshotBinPath),
- '--output_bin=%s' % binarySnapshotFile,
+ '--vm_output_bin=%s' % binaryVmIsolateSnapshotFile,
+ '--output_bin=%s' % binaryIsolateSnapshotFile,
'--script=%s' % snapshotScriptName,
]
command.extend(['--url_mapping=dart:%s,%s' % lib for lib in snapshottedLibs])
@@ -93,7 +96,8 @@ def main(args):
'python',
path(dartPath, 'runtime', 'tools', 'create_snapshot_file.py'),
'--input_cc=%s' % dartSnapshotTemplateFile,
- '--input_bin=%s' % binarySnapshotFile,
+ '--vm_input_bin=%s' % binaryVmIsolateSnapshotFile,
+ '--input_bin=%s' % binaryIsolateSnapshotFile,
'--output=%s' % path(outputFilePath, 'DartSnapshot.bytes'),
]
@@ -104,7 +108,7 @@ def main(args):
if (pipe.returncode != 0):
raise Exception('Snapshot file generation failed: %s/%s' % (out, error))
- snapshotSizeInBytes = os.path.getsize(binarySnapshotFile)
+ snapshotSizeInBytes = os.path.getsize(binaryIsolateSnapshotFile)
productDir = os.path.dirname(genSnapshotBinPath)
snapshotSizeOutputPath = os.path.join(productDir, 'snapshot-size.txt')
with file(snapshotSizeOutputPath, 'w') as snapshotSizeFile:
« no previous file with comments | « bindings/README ('k') | bindings/dart/scripts/__init__.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698