Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1203)

Unified Diff: core/dom/URL.idl

Issue 1660113002: Updated to Chrome 45 (2454) moved from SVN to git. Base URL: https://github.com/dart-lang/webcore.git@roll_45
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « core/dom/TreeWalker.idl ('k') | core/dom/URLUtils.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: core/dom/URL.idl
diff --git a/core/dom/URL.idl b/core/dom/URL.idl
index 64f14fbf6808bea9e27f79e752e8690e97a529d9..8bd952734b4b7d3621bb795cb31ec216c898639b 100644
--- a/core/dom/URL.idl
+++ b/core/dom/URL.idl
@@ -24,20 +24,28 @@
* THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-// http://url.spec.whatwg.org/#url
+// https://url.spec.whatwg.org/#url
[
- Constructor(ScalarValueString url),
- Constructor(ScalarValueString url, ScalarValueString base),
- Constructor(ScalarValueString url, URL base),
+ // TODO(philipj): There should only be one constructor:
+ // Constructor(USVString url, optional USVString base)
+ Constructor(USVString url),
+ Constructor(USVString url, USVString base),
+ Constructor(USVString url, URL base),
Exposed=(Window,Worker),
ImplementedAs=DOMURL,
RaisesException=Constructor,
- WillBeGarbageCollected,
+ GarbageCollected,
] interface URL {
- // FIXME: should be in separate URLBlob.idl partial interface definition
- // http://dev.w3.org/2006/webapi/FileAPI/#URL-object
- // FIXME: should not be nullable
+ // TODO(philipj): Implement domainToASCII() and domainToUnicode().
+ // crbug.com/493908
+ // static USVString domainToASCII(USVString domain);
+ // static USVString domainToUnicode(USVString domain);
+
+ // TODO(philipj): This should be in a partial interface definition:
+ // File API
+ // https://w3c.github.io/FileAPI/#creating-revoking
+ // TODO(philipj): Neither the return value nor the argument should be nullable.
[RaisesException, CallWith=ExecutionContext] static DOMString? createObjectURL(Blob? blob);
[CallWith=ExecutionContext] static void revokeObjectURL(DOMString url);
};
« no previous file with comments | « core/dom/TreeWalker.idl ('k') | core/dom/URLUtils.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698