Reland of WebRTC: Use the MediaStream Recording API for the audio_quality_browsertest.

Reland of WebRTC: Use the MediaStream Recording API for the audio_quality_browsertest. (patchset #1 id:1 of https://codereview.chromium.org/2773803002/ )

Reason for revert:

- We fixed some issues with the MOS score.
- We made sure to have a download directory per fixture, and to erase it after converting the webm file to a wav file.
- We moved that code to SetUpOnMainThread.


Original issue's description:
> Revert of WebRTC: Use the MediaStream Recording API for the audio_quality_browsertest. (patchset #8 id:140001 of https://codereview.chromium.org/2753543010/ )
> 
> Reason for revert:
> This might be causing failures in Win7 bots:
> 
> https://build.chromium.org/p/chromium.webrtc/builders/Win7%20Tester/builds/34106
> 
> Original issue's description:
> > WebRTC: Use the MediaStream Recording API for the audio_quality_browsertest.
> > 
> > This CL uses the MediaStream Recording API to record the audio received
> > by the right tag. It saves it as a webm file that is later converted to a
> > wav file using ffmpeg.
> > 
> > This might cause a performance regression because we're using webm+ffmpeg
> > to generate the wav file. I set a, hopefully high enough, bitrate to
> > mitigate this
> > 
> > BUG=chromium:681577
> > NOTRY=True
> > 
> > Review-Url: https://codereview.chromium.org/2753543010
> > Cr-Commit-Position: refs/heads/master@{#459050}
> > Committed: https://chromium.googlesource.com/chromium/src/+/a0a47bfebb016ec468bc6d1b4be9b1acb22a4075
> 
> TBR=kjellander@chromium.org,hbos@chromium.org,mcasas@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=chromium:681577
> 
> Review-Url: https://codereview.chromium.org/2773803002
> Cr-Commit-Position: refs/heads/master@{#459234}
> Committed: https://chromium.googlesource.com/chromium/src/+/e512d162ed486a0a9f71a1e20e3cde8fb20255e1

TBR=kjellander@chromium.org,hbos@chromium.org,mcasas@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:681577

[ehmaldonado_chromium, 2017-03-24 12:02:52]

Created Reland of WebRTC: Use the MediaStream Recording API for the
audio_quality_browsertest.

[mcasas, 2017-03-24 17:31:23]

On 2017/03/24 12:02:52, ehmaldonado_chromium wrote:
> Created Reland of WebRTC: Use the MediaStream Recording API for the
> audio_quality_browsertest.

When preparing a reland, please make the first patch look like
reverted CL and add the changes in subsequent CLs, to facilitate
review (e.g. like in https://crrev.com/2734703002/).
Also, I don't see any detail of the fix in the CL description. 
From the bot logs, it seems like they didn't pick the file.

[ehmaldonado_chromium, 2017-03-24 18:11:43]

On 2017/03/24 17:31:23, mcasas wrote:
> On 2017/03/24 12:02:52, ehmaldonado_chromium wrote:
> > Created Reland of WebRTC: Use the MediaStream Recording API for the
> > audio_quality_browsertest.
> 
> When preparing a reland, please make the first patch look like
> reverted CL and add the changes in subsequent CLs, to facilitate
> review (e.g. like in https://crrev.com/2734703002/).
> Also, I don't see any detail of the fix in the CL description. 
> From the bot logs, it seems like they didn't pick the file.

I haven't made any changes yet. I used the bot to get access to a built binary
so I could test in my laptop

[ehmaldonado_chromium, 2017-03-30 16:19:05]

Patchset #2 (id:110001) has been deleted

[ehmaldonado_chromium, 2017-03-30 17:20:53]

On 2017/03/24 18:11:43, ehmaldonado_chromium wrote:
> On 2017/03/24 17:31:23, mcasas wrote:
> > On 2017/03/24 12:02:52, ehmaldonado_chromium wrote:
> > > Created Reland of WebRTC: Use the MediaStream Recording API for the
> > > audio_quality_browsertest.
> > 
> > When preparing a reland, please make the first patch look like
> > reverted CL and add the changes in subsequent CLs, to facilitate
> > review (e.g. like in https://crrev.com/2734703002/).
> > Also, I don't see any detail of the fix in the CL description. 
> > From the bot logs, it seems like they didn't pick the file.
> 
> I haven't made any changes yet. I used the bot to get access to a built binary
> so I could test in my laptop

I made a couple of changes, mostly to fix the MOS scores.
I don't know why it failed on the bots, I can't reproduce it locally.

[kjellander_chromium, 2017-03-30 19:26:34]

lgtm
It's worth a try to reland and see how it works. Were you able to manufacture a
patch that would run the test on the trybots?

Also, please update the CL description a little to reflect the changes (instead
of just "Reason for revert: Investigating...").

https://codereview.chromium.org/2773083002/diff/130001/chrome/browser/media/w...
File chrome/browser/media/webrtc/webrtc_audio_quality_browsertest.cc (right):

https://codereview.chromium.org/2773083002/diff/130001/chrome/browser/media/w...
chrome/browser/media/webrtc/webrtc_audio_quality_browsertest.cc:107: void
SetUpOnMainThread() override {
Does moving this to SetUpOnMainThread() do any difference? Do you think it can
solve the problem on Windows? I guess since we cannot repro, it's still worth a
try...

[ehmaldonado_chromium, 2017-03-30 19:34:15]

I couldn't manufacture a patch, since we need at least the reference file to
play it on the bots.
But now that I think about it, I think I could try using the fake one with the
beeps.

[ehmaldonado_chromium, 2017-03-31 09:50:50]

Description was changed from

==========
Reland of WebRTC: Use the MediaStream Recording API for the
audio_quality_browsertest. (patchset #1 id:1 of
https://codereview.chromium.org/2773803002/ )

Reason for revert:
Investigating...

Original issue's description:
> Revert of WebRTC: Use the MediaStream Recording API for the
audio_quality_browsertest. (patchset #8 id:140001 of
https://codereview.chromium.org/2753543010/ )
> 
> Reason for revert:
> This might be causing failures in Win7 bots:
> 
>
https://build.chromium.org/p/chromium.webrtc/builders/Win7%20Tester/builds/34106
> 
> Original issue's description:
> > WebRTC: Use the MediaStream Recording API for the audio_quality_browsertest.
> > 
> > This CL uses the MediaStream Recording API to record the audio received
> > by the right tag. It saves it as a webm file that is later converted to a
> > wav file using ffmpeg.
> > 
> > This might cause a performance regression because we're using webm+ffmpeg
> > to generate the wav file. I set a, hopefully high enough, bitrate to
> > mitigate this
> > 
> > BUG=chromium:681577
> > NOTRY=True
> > 
> > Review-Url: https://codereview.chromium.org/2753543010
> > Cr-Commit-Position: refs/heads/master@{#459050}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/a0a47bfebb016ec468bc6d1b4be9...
> 
> TBR=kjellander@chromium.org,hbos@chromium.org,mcasas@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=chromium:681577
> 
> Review-Url: https://codereview.chromium.org/2773803002
> Cr-Commit-Position: refs/heads/master@{#459234}
> Committed:
https://chromium.googlesource.com/chromium/src/+/e512d162ed486a0a9f71a1e20e3c...

TBR=kjellander@chromium.org,hbos@chromium.org,mcasas@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:681577
==========

to

==========
Reland of WebRTC: Use the MediaStream Recording API for the
audio_quality_browsertest. (patchset #1 id:1 of
https://codereview.chromium.org/2773803002/ )

Reason for revert:
We fixed some issues with the MOS score, made sure to have a download directory
per fixture, and to erase it after converting the webm file to a wav file.


Original issue's description:
> Revert of WebRTC: Use the MediaStream Recording API for the
audio_quality_browsertest. (patchset #8 id:140001 of
https://codereview.chromium.org/2753543010/ )
> 
> Reason for revert:
> This might be causing failures in Win7 bots:
> 
>
https://build.chromium.org/p/chromium.webrtc/builders/Win7%20Tester/builds/34106
> 
> Original issue's description:
> > WebRTC: Use the MediaStream Recording API for the audio_quality_browsertest.
> > 
> > This CL uses the MediaStream Recording API to record the audio received
> > by the right tag. It saves it as a webm file that is later converted to a
> > wav file using ffmpeg.
> > 
> > This might cause a performance regression because we're using webm+ffmpeg
> > to generate the wav file. I set a, hopefully high enough, bitrate to
> > mitigate this
> > 
> > BUG=chromium:681577
> > NOTRY=True
> > 
> > Review-Url: https://codereview.chromium.org/2753543010
> > Cr-Commit-Position: refs/heads/master@{#459050}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/a0a47bfebb016ec468bc6d1b4be9...
> 
> TBR=kjellander@chromium.org,hbos@chromium.org,mcasas@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=chromium:681577
> 
> Review-Url: https://codereview.chromium.org/2773803002
> Cr-Commit-Position: refs/heads/master@{#459234}
> Committed:
https://chromium.googlesource.com/chromium/src/+/e512d162ed486a0a9f71a1e20e3c...

TBR=kjellander@chromium.org,hbos@chromium.org,mcasas@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:681577
==========

[ehmaldonado_chromium, 2017-03-31 10:43:53]

Description was changed from

==========
Reland of WebRTC: Use the MediaStream Recording API for the
audio_quality_browsertest. (patchset #1 id:1 of
https://codereview.chromium.org/2773803002/ )

Reason for revert:
We fixed some issues with the MOS score, made sure to have a download directory
per fixture, and to erase it after converting the webm file to a wav file.


Original issue's description:
> Revert of WebRTC: Use the MediaStream Recording API for the
audio_quality_browsertest. (patchset #8 id:140001 of
https://codereview.chromium.org/2753543010/ )
> 
> Reason for revert:
> This might be causing failures in Win7 bots:
> 
>
https://build.chromium.org/p/chromium.webrtc/builders/Win7%20Tester/builds/34106
> 
> Original issue's description:
> > WebRTC: Use the MediaStream Recording API for the audio_quality_browsertest.
> > 
> > This CL uses the MediaStream Recording API to record the audio received
> > by the right tag. It saves it as a webm file that is later converted to a
> > wav file using ffmpeg.
> > 
> > This might cause a performance regression because we're using webm+ffmpeg
> > to generate the wav file. I set a, hopefully high enough, bitrate to
> > mitigate this
> > 
> > BUG=chromium:681577
> > NOTRY=True
> > 
> > Review-Url: https://codereview.chromium.org/2753543010
> > Cr-Commit-Position: refs/heads/master@{#459050}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/a0a47bfebb016ec468bc6d1b4be9...
> 
> TBR=kjellander@chromium.org,hbos@chromium.org,mcasas@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=chromium:681577
> 
> Review-Url: https://codereview.chromium.org/2773803002
> Cr-Commit-Position: refs/heads/master@{#459234}
> Committed:
https://chromium.googlesource.com/chromium/src/+/e512d162ed486a0a9f71a1e20e3c...

TBR=kjellander@chromium.org,hbos@chromium.org,mcasas@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:681577
==========

to

==========
Reland of WebRTC: Use the MediaStream Recording API for the
audio_quality_browsertest. (patchset #1 id:1 of
https://codereview.chromium.org/2773803002/ )

Reason for revert:

- We fixed some issues with the MOS score.
- We made sure to have a download directory per fixture, and to erase it after
converting the webm file to a wav file.
- We moved that code to SetUpOnMainThread.


Original issue's description:
> Revert of WebRTC: Use the MediaStream Recording API for the
audio_quality_browsertest. (patchset #8 id:140001 of
https://codereview.chromium.org/2753543010/ )
> 
> Reason for revert:
> This might be causing failures in Win7 bots:
> 
>
https://build.chromium.org/p/chromium.webrtc/builders/Win7%20Tester/builds/34106
> 
> Original issue's description:
> > WebRTC: Use the MediaStream Recording API for the audio_quality_browsertest.
> > 
> > This CL uses the MediaStream Recording API to record the audio received
> > by the right tag. It saves it as a webm file that is later converted to a
> > wav file using ffmpeg.
> > 
> > This might cause a performance regression because we're using webm+ffmpeg
> > to generate the wav file. I set a, hopefully high enough, bitrate to
> > mitigate this
> > 
> > BUG=chromium:681577
> > NOTRY=True
> > 
> > Review-Url: https://codereview.chromium.org/2753543010
> > Cr-Commit-Position: refs/heads/master@{#459050}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/a0a47bfebb016ec468bc6d1b4be9...
> 
> TBR=kjellander@chromium.org,hbos@chromium.org,mcasas@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=chromium:681577
> 
> Review-Url: https://codereview.chromium.org/2773803002
> Cr-Commit-Position: refs/heads/master@{#459234}
> Committed:
https://chromium.googlesource.com/chromium/src/+/e512d162ed486a0a9f71a1e20e3c...

TBR=kjellander@chromium.org,hbos@chromium.org,mcasas@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:681577
==========

[kjellander_chromium, 2017-09-29 07:06:19]

kjellander@chromium.org changed reviewers:
+ phoglund@chromium.org

[kjellander_chromium, 2017-09-29 07:06:20]

What happened to this?